Skip to content

chore(readme): use lower-case header name - #866

Merged
titanism merged 1 commit into
forwardemail:masterfrom
SchroederSteffen:use-lowercase-header-name
Dec 29, 2025
Merged

titanism merged 1 commit into
forwardemail:masterfrom
SchroederSteffen:use-lowercase-header-name

Conversation

@SchroederSteffen

@SchroederSteffen SchroederSteffen commented Jul 25, 2025 •

Copy link
Copy Markdown
Contributor

Fix #859, see #859 (comment).

HTTP headers are supposed to be case-insensitive and superagent lower-cases them to unify the case.
The example in the README doesn't work, because it uses Content-Type instead of content-type. This PR fixes the example.

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@A1exKH A1exKH left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@titanism
titanism merged commit 0666797 into forwardemail:master Dec 29, 2025
@SchroederSteffen
SchroederSteffen deleted the use-lowercase-header-name branch December 29, 2025 11:42
@titanism

titanism commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator

v7.2.0 published to npm

https://github.com/forwardemail/supertest/releases/tag/v7.2.0

please consider supporting our maintenance efforts by becoming a @forwardemail user! **sign up at https://forwardemail.net and use coupon code GITHUB for 100% off 馃檹 **

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content-Type header not being properly asserted

3 participants