Skip to content

replace Sage's closest vector by fpylll's code? #176

Open

Description

@dimpase

We now have to deal with Sage's IntegerLattice bugs on https://trac.sagemath.org/ticket/29866 - and
it appears that for some reason Sage does not use fpylll's code for closest_vector, but does something on its own (and that got broken in Sage 8.5, as it turned out).

On the example showing Sage's bug, fpylll does the job just fine. Would it be beneficial to replace Sage's code with a code that just calls fpylll ?

Activity

  1. malb commented on Jun 16, 2020

    @malb
    Collaborator

    FP(y)LLL only permits integer target vectors, but Sage's current code handles rational target vectors too. This is mostly an interface issue but still.

  2. dimpase commented on Jun 16, 2020

    @dimpase
    Author

    Does FP(y)LLL have code to compute the Voronoi cell?
    Further digging on the Sage ticket points at a mysterious breakage in calculate_voronoi_cell()

  3. malb commented on Jun 17, 2020

    @malb
    Collaborator

    Nope. Well, a sieving db is an approximate Voronoi cell so G6K could be used, but it would be heuristic and not provable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions