Add IsNone, IsSome and IsChoiceXOfY variants - #354
Merged
Merged
Conversation
panesofglass
requested changes
Mar 29, 2018
panesofglass
left a comment
panesofglass
left a comment
Contributor
There was a problem hiding this comment.
Overall, I like the additions. Please resolve the conflicts and the requested change below, and I'll be happy to merge.
| function | ||
| | Some x -> x | ||
| | None -> failwithf fmt | ||
|
|
Contributor
There was a problem hiding this comment.
Rather than just removing this function, please add an ObsoleteAttribute to explain that it will be removed in a future release and which function should be used instead.
Contributor
Author
There was a problem hiding this comment.
the function has been introduced quite recently, and it's broken by design from the beginning and there's no substitute -- it just doesn't work
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.