Improve c# compatibility - #376
Merged
panesofglass merged 2 commits intoOct 21, 2019
Merged
Conversation
Contributor
|
@wallymathieu, this is excellent! Sorry, I only just saw the PR. Any idea as to why the build is failing? |
Contributor
|
Seems the build failure may be unrelated to the changes. |
Member
Author
|
perhaps a need to update the FSharpx.Extras with new paket and FAKE? |
panesofglass
approved these changes
Oct 3, 2019
Contributor
|
@forki any ideas about the build issue? |
Member
Author
|
I'm trying out some changes in order to make it nicer to use in c#: FSharpChoice works better as Choices |
Contributor
|
@wallymathieu any updates, or would you like me to merge? |
Member
Author
|
Fixing the build error would probably be a separate pull request. |
Member
Author
|
So yes, please merge the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.