Add ofOptionF to Result module - #377
Merged
Merged
Conversation
Add Result.ofOptionF in order to create a result from an option using a function to supply the default value. Using a function enables the error object to be resolved when needed instead of up-front.
Contributor
|
Thank you for your PR. I'm not sure about the naming. Might |
Author
|
@panesofglass Maybe it is. I choose the name based on the existing function Result.ofOption and the F convention I picked up from Option.getOrElseF Do you think I should change the name to mapOption? Is it okay to have .ofOption (o : 'a) and .mapOption (f : unit -> 'a) |
Contributor
|
I had forgotten about |
panesofglass
self-requested a review
October 3, 2019 19:09
Author
Any update on this? |
panesofglass
approved these changes
Oct 21, 2019
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Result.ofOptionF in order to create a result from an option using a
function to supply the default value.
Using a function enables the error object to be resolved when needed
instead of up-front.