Skip to content
This repository was archived by the owner on Jun 1, 2026. It is now read-only.

Add review-changes skill and update AGENTS.md - #912

Merged
0xh3rman merged 2 commits into
mainfrom
local-change-skill
Jan 27, 2026
Merged

0xh3rman merged 2 commits into
mainfrom
local-change-skill

Conversation

@0xh3rman

Copy link
Copy Markdown
Collaborator

No description provided.

@semanticdiff-com

Copy link
Copy Markdown

Review changes with  SemanticDiff

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's automated code quality tooling and documentation. It introduces a new review-changes skill designed to enforce coding standards across the codebase, providing a structured approach to identifying and rectifying common issues. Concurrently, the AGENTS.md documentation has been revised to incorporate these new standards, offering clearer guidance on code style, error handling, and organization. These changes aim to improve code consistency, maintainability, and developer efficiency by leveraging automation and updated best practices.

Highlights

  • New review-changes Skill Added: A comprehensive new skill has been introduced to automate the review and fixing of local git changes against defined coding standards. This skill includes a detailed checklist covering various aspects of Rust development, from import patterns and naming conventions to error handling, code style, organization, async, database, blockchain/RPC patterns, testing, and security.
  • Updated Coding Standards Documentation: The AGENTS.md file has been significantly updated to reflect new and refined coding guidelines. Key changes include updated rustfmt usage, new rules against type suffixes and unsolicited documentation, a shift in error handling preference from thiserror to plain Error types, and a new extensive section on code organization. Recommendations for hex encoding/decoding have also been updated to use primitives::hex.
  • Removed push_pr Command Documentation: The documentation for the automatic push_pr command, located at .claude/commands/push_pr.md, has been removed from the repository.
  • Rustfmt Edition Update: The rustfmt.toml configuration file has been updated to explicitly set the edition = "2024", aligning the project's formatting with the latest Rust edition.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new review-changes skill for automated code review and updates the AGENTS.md documentation to align with new coding standards. The changes are well-structured and aim to improve code consistency. However, I've found a few issues in the new documentation and skill definition: an inconsistency in the specified line length and invalid code examples for uniffi::remote that would lead to compilation errors. Addressing these points will improve the accuracy and usefulness of the new documentation.

Comment thread .claude/skills/review-changes/SKILL.md
Comment thread AGENTS.md
Comment thread .claude/skills/review-changes/SKILL.md Outdated
@0xh3rman
0xh3rman merged commit d7cd734 into main Jan 27, 2026
5 checks passed
@0xh3rman
0xh3rman deleted the local-change-skill branch January 27, 2026 11:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant