This repository was archived by the owner on Jun 1, 2026. It is now read-only.
Repository navigation
Replace unwrap_or with BigNumberFormatter for Tron stake amount parsing - #923
Merged
Merged
Conversation
Changed Files
|
Merged
Co-authored-by: gemcoder21 <[email protected]>
Copilot
AI
changed the title
[WIP] Fix BigNumberFormatter usage in Tron unstake PR
Replace unwrap_or with BigNumberFormatter for Tron stake amount parsing
Feb 3, 2026
gemcoder21
marked this pull request as ready for review
February 3, 2026 22:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback to use
BigNumberFormatterinstead ofunwrap_or(0)for parsing stake amounts in Tron preload logic, ensuring proper error propagation and consistent number formatting.Changes:
input.value.parse::<u64>().unwrap_or(0) / 10_u64.pow(asset.decimals as u32)withBigNumberFormatter::value_as_u64(&input.value, asset.decimals as u32)?for decimal conversioninput.value.parse().unwrap_or(0)withBigNumberFormatter::value_as_u64(&input.value, 0)?for base unit parsingnumber_formatterdependency togem_troncrate withrpcfeatureBefore:
After:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.