Skip to content
This repository was archived by the owner on Jun 1, 2026. It is now read-only.

Update Monad staking lens and check if rewards is 0 - #945

Merged
0xh3rman merged 2 commits into
mainfrom
monad-staking-fix
Feb 12, 2026
Merged

0xh3rman merged 2 commits into
mainfrom
monad-staking-fix

Conversation

@0xh3rman

Copy link
Copy Markdown
Collaborator

No description provided.

@semanticdiff-com

semanticdiff-com Bot commented Feb 11, 2026 •

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  crates/gem_evm/src/provider/staking_monad.rs  4% smaller
  crates/gem_evm/src/monad/constants.rs  0% smaller

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the Monad staking integration by updating a critical contract address and improving the data processing logic. The changes ensure that the system interacts with the correct staking lens contract and more accurately filters out irrelevant staking positions by considering both the staked amount and accumulated rewards.

Highlights

  • Staking Lens Contract Update: The STAKING_LENS_CONTRACT address in monad/constants.rs has been updated to a new value.
  • Staking Position Filtering Logic: The logic for filtering staking positions in staking_monad.rs has been enhanced to also check if the rewards amount is zero, in addition to checking if the amount is zero.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • crates/gem_evm/src/monad/constants.rs
    • Updated the STAKING_LENS_CONTRACT address.
  • crates/gem_evm/src/provider/staking_monad.rs
    • Modified the condition for filtering staking positions to also check if rewards are zero.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Monad staking lens contract address and improves the logic for handling staking positions. The change ensures that delegations with a zero staked amount but available rewards are no longer filtered out, which is a correct and necessary fix. The changes are clear and well-implemented.

@0xh3rman
0xh3rman merged commit 92e5904 into main Feb 12, 2026
4 checks passed
@0xh3rman
0xh3rman deleted the monad-staking-fix branch February 12, 2026 02:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants