Repository navigation
Upgrade Gradle/Kotlin toolchain and test app deps - #948
Conversation
Bump Gradle wrapper and plugin toolchain settings, enable Foojay toolchain resolver, and adjust project Gradle/Kotlin versions. Key changes: - Update root Android build plugins: com.android.application -> 8.13.2, Kotlin plugin -> 2.3.10. - Add org.gradle.toolchains.foojay-resolver-convention plugin and new gradle-daemon-jvm.properties files to pin toolchain URLs/vendor/version. - Update Gradle wrapper distributions: project -> 8.14.4; GemTest -> 9.2.1 (added distributionSha256Sum for GemTest wrapper). - Add Android Gradle properties (android.builtInKotlin=false, android.newDsl=false) to root and expand several Android flags for the GemTest module. - GemTest build: bump Kotlin and Android plugin versions (Kotlin 2.3.10, com.android.application 9.0.0), add Compose plugin and plugin dependency for Kotlin Compose. - Bump test app dependencies: JNA 5.15.0 -> 5.18.1, gemstone AAR 1.0.0 -> 1.0.3. - Code adjustments in test app: switch HTTP method usage to AlienHttpMethod/alienMethodToString and use immutable Map for headers; replace AlienError.RequestError with AlienException.RequestException. These changes prepare the project for newer Gradle/Kotlin toolchains, update test dependencies, and adapt test code to API changes.
|
Review changes with |
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the project's Gradle and Kotlin toolchain, ensuring compatibility with newer build environments and leveraging modern features. It also updates key dependencies for the test application and adapts existing code to reflect API changes in the underlying libraries. These changes collectively prepare the project for future development and maintain a robust build system. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively upgrades the Gradle and Kotlin toolchains, along with several test application dependencies. The changes are well-structured, including the adoption of the Foojay toolchain resolver and necessary code adjustments for new dependency APIs. My review found one area for improvement in the Gradle configuration for the test app, where some newly added properties are obsolete with the upgraded Android Gradle Plugin version and should be removed for better maintainability. Overall, this is a solid update that modernizes the project's build setup.
1 participant
Bump Gradle wrapper and plugin toolchain settings, enable Foojay toolchain resolver, and adjust project Gradle/Kotlin versions. Key changes:
These changes prepare the project for newer Gradle/Kotlin toolchains, update test dependencies, and adapt test code to API changes.