Repository navigation
Update Jupiter v6 and remove auto-slippage - #950
Conversation
Update models and provider to align with Jupiter API V2: replace auto_slippage/max_auto_slippage_bps with an instruction_version field in QuoteRequest/QuoteResponse, remove DynamicSlippage and dynamic_slippage usage, and pass a constant INSTRUCTION_VERSION ("V2") when requesting quotes. Adjust provider logic to use swap_quote.slippage_bps directly and remove computed auto-slippage handling. Also change Solana default slippage mode to Exact (with increased bps) in config.
|
Review changes with Changed Files
|
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the Jupiter integration by adapting to the v6 API changes. The primary goal is to streamline how slippage is handled, moving away from an auto-slippage mechanism to a more explicit instruction version. This change simplifies the API interaction and ensures compatibility with the latest Jupiter features, improving the reliability and clarity of swap operations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully updates the Jupiter provider to align with its v6 API. The changes correctly replace the deprecated auto-slippage functionality with the instruction_version field in the request and response models. The related logic for DynamicSlippage and computed_auto_slippage has been properly removed. Additionally, the default slippage mode for Solana is updated to Exact, which is consistent with the removal of auto-slippage features. The code modifications are clean, well-contained, and directly address the requirements of the Jupiter v6 migration. The changes look good to me.
2 participants
Fixes #947
Update models and provider to align with Jupiter v6:
Tested txs: