Skip to content
This repository was archived by the owner on Jun 1, 2026. It is now read-only.

Repository navigation

Add OKX DEX for Solana swap - #952

Merged
0xh3rman merged 1 commit into
mainfrom
okx-dex
Feb 17, 2026
Merged

Add OKX DEX for Solana swap#952
0xh3rman merged 1 commit into
mainfrom
okx-dex

Conversation

@0xh3rman

@0xh3rman 0xh3rman commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

It's driven by swapper in core-ts

@semanticdiff-com

semanticdiff-com Bot commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  gemstone/src/block_explorer/mod.rs  92% smaller
  crates/swapper/src/models.rs  89% smaller
  crates/primitives/src/swap_provider.rs  21% smaller
  crates/swapper/src/swapper.rs  17% smaller
  crates/swapper/src/proxy/provider.rs  0% smaller
  crates/swapper/src/proxy/provider_factory.rs  0% smaller
  gemstone/src/gem_swapper/remote_types.rs  0% smaller

@0xh3rman 0xh3rman changed the title add okx dex for solana Add OKX DEX for Solana swap Feb 17, 2026
@gemini-code-assist

gemini-code-assist Bot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for the OKX decentralized exchange (DEX) specifically for the Solana blockchain. The changes involve updating core enums to include OKX, implementing its provider logic, and integrating it into the main swapper component, thereby expanding the platform's trading capabilities on Solana.

Highlights

  • New DEX Integration: The OKX decentralized exchange (DEX) has been integrated as a new swap provider for Solana.
  • Enum Updates: The Okx variant was added to both SwapProvider and SwapperProvider enums across the codebase to recognize the new provider.
  • Provider Initialization: New factory methods and initialization logic were introduced to correctly instantiate and register the OKX swap provider within the system.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • crates/primitives/src/swap_provider.rs
    • Added Okx variant to the SwapProvider enum.
    • Mapped Self::Okx to the string "OKX" in the impl SwapProvider block.
    • Included Self::Okx in the is_solana_dex match arm.
  • crates/swapper/src/models.rs
    • Added SwapperProvider::Okx to the SwapProviderMode::OnChain match arm.
  • crates/swapper/src/proxy/provider.rs
    • Added a public function new_okx to create a ProxyProvider for Okx on Solana.
  • crates/swapper/src/proxy/provider_factory.rs
    • Added a public factory function new_okx that delegates to ProxyProvider::new_okx.
  • crates/swapper/src/swapper.rs
    • Instantiated and boxed provider_factory::new_okx within the GemSwapper::new method.
  • gemstone/src/block_explorer/mod.rs
    • Added SwapperProvider::Okx to the match arm that uses get_block_explorer for Solana DEXes.
  • gemstone/src/gem_swapper/remote_types.rs
    • Added Okx variant to the SwapperProvider enum.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 17, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for OKX DEX as a new swap provider for Solana. The changes are straightforward and consistently follow the existing pattern for adding new providers. I've added a few suggestions to improve code organization and maintainability by sorting enum variants and match arms alphabetically, and by grouping related providers. These are optional but would improve the codebase in the long run.

Comment thread crates/primitives/src/swap_provider.rs
Comment thread crates/primitives/src/swap_provider.rs
Comment thread crates/swapper/src/swapper.rs
Comment thread gemstone/src/gem_swapper/remote_types.rs
@0xh3rman
0xh3rman marked this pull request as ready for review February 17, 2026 06:45
@0xh3rman
0xh3rman merged commit 85aae3f into main Feb 17, 2026
6 checks passed
@0xh3rman
0xh3rman deleted the okx-dex branch February 17, 2026 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
@gemcoder21 gemcoder21 gemcoder21 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xh3rman @gemcoder21