Repository navigation
Conversation
Add a MAX_NAME_LENGTH (20) constant and import NameError; the resolve method now checks the first label (before the first '.') and returns an error if it exceeds the maximum length to avoid resolving invalid/oversized names. Also add an async unit test to verify that overly long names are rejected.
|
Review changes with Changed Files
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Injective name resolution client by implementing a crucial validation step. It introduces a maximum length constraint for Injective names, preventing the resolution of invalid or oversized names. This ensures greater data integrity and robustness in the name resolution process, with an accompanying test to confirm the new behavior. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly implements a length check for Injective names by adding a MAX_NAME_LENGTH constant and validating the name in the resolve method. The addition of a unit test to verify this behavior is also a good practice. I have a couple of suggestions to make the code more idiomatic and the test more robust.
0xh3rman
changed the title
1 participant
Add a MAX_NAME_LENGTH (20) constant and import NameError; the resolve method now checks the first label (before the first '.') and returns an error if it exceeds the maximum length to avoid resolving invalid/oversized names. Also add an async unit test to verify that overly long names are rejected.