Repository navigation
Change panic mode to default/unwind - #981
Conversation
Delete the explicit panic = "abort" setting from gemstone/.cargo/config.toml so the workspace will use Rust's default panic strategy (typically unwind). This improves compatibility with tests, debugging and libraries that require unwinding.
|
Review changes with |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the project's build configuration to align with Rust's default panic handling. By removing a specific Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the panic = "abort" setting from the gemstone crate's local Cargo configuration for the release profile. By doing so, it reverts to Rust's default panic strategy, which is typically unwind. This change is beneficial as it improves compatibility with testing, debugging, and especially foreign function interface (FFI) boundaries, where unwinding is necessary to catch panics and prevent them from causing undefined behavior in the host application. The change is correct and aligns with best practices for building Rust libraries intended for FFI.
Note: Security Review has been skipped due to the limited scope of the PR.
2 participants
Delete the explicit panic = "abort" setting from gemstone/.cargo/config.toml so the workspace will use Rust's default panic strategy (typically unwind). This improves compatibility with tests, debugging and libraries that require unwinding.