Skip to content

Fix for issue with loading step impls from relative dirs - #430

Merged
chadlwilson merged 4 commits into
getgauge:masterfrom
kunalvishwasrao:feature/fix-impl-loader-file
Mar 29, 2025
Merged

chadlwilson merged 4 commits into
getgauge:masterfrom
kunalvishwasrao:feature/fix-impl-loader-file

Conversation

@kunalvishwasrao

Copy link
Copy Markdown
Contributor

Fix for issue #429:

  • Updated the file path check for relative paths in impl_loader file
  • Added a test in 'test_impl_loader' file to check for the specific scenario with ".." in between the file path

Hey @zabil, @chadlwilson can you please help me out with the review for this PR?

Thanks!

@gaugebot

gaugebot Bot commented Mar 29, 2025

Copy link
Copy Markdown

@kunalvishwasrao Thank you for contributing to gauge-python. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

Signed-off-by: Chad Wilson <[email protected]>
@chadlwilson
chadlwilson merged commit 5ad2747 into getgauge:master Mar 29, 2025
@chadlwilson

Copy link
Copy Markdown
Contributor

Thanks! Sorry this regressed here :-/

@kunalvishwasrao

kunalvishwasrao commented Mar 29, 2025 •

Copy link
Copy Markdown
Contributor Author

Thanks! Sorry this regressed here :-/

You're welcome!
No worries, was happy could help! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants