Skip to content

[helios] All buttons of the forms plugin are without css style #617

Description

@Gleydar

First of all, let me preface this by saying that I'm not sure, if this is a bug at all. I just observed this behavior and thought to bring it up here.

Observation

When generating a form via the forms plugin, all specified buttons are without any css style.
I would expect buttons to look identical to the [doc-button] shortcode.

Analysis

This seems to occur because the forms plugin generates its buttons with a <button ... class="button"> tag.
In its css, Helios specifies css for buttons:

  button, input, select, optgroup, textarea, ::file-selector-button {
    font: inherit;
    font-feature-settings: inherit;
    font-variation-settings: inherit;
    letter-spacing: inherit;
    color: inherit;
    border-radius: 0;
    background-color: transparent;
    opacity: 1;
  }

However, there is nothing to inherit.

In contrast, [doc-button] buttons are generated with a doc-button class. When switching the class of a form-button in the browser inspector, the buttons are rendered as I would expect.

Reproduction

To reproduce, create a sample page

---
title: Test-Form
form:
  name: contact
  fields:
    name:
      label: Name
      placeholder: Enter your name
      autocomplete: 'on'
      type: text
      validate:
        required: true
    message:
      label: Message
      placeholder: Enter your message
      type: textarea
      validate:
        required: true
  buttons:
    submit:
      type: submit
      value: Submit
    reset:
      type: reset
      value: Reset
---

When opening the created page, all buttons are transparent

Image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions