Repository navigation
Update type signatures to avoid warnings in PHP 8.1 - #172
Closed
someonewithpc wants to merge 1 commit into
Closed
someonewithpc wants to merge 1 commit into
someonewithpc wants to merge 1 commit into
Conversation
Member
|
I'm wondering why the CI was not executed 😞 (I guess it is my fault) have you executed tests in earlier php versions? |
tflori
reviewed
Jan 3, 2022
| * @param mixed $options | ||
| */ | ||
| public function __construct($name, $handler, $options = null) | ||
| final public function __construct($name, $handler, $options = null) |
Member
There was a problem hiding this comment.
Is that one the warnings from phpstan?
I don't want to restrict the constructor. If someone wants to overwrite the constructors - I'm fine. So why to declare it final? If you still can overwrite the constructor (even more: it means the final keyword has no effect on constructors) I would especially not add this keyword.
In conclusion I would not add final for one or the other reason:
a) they should not be final
b) it might even be ignored from php
Author
There was a problem hiding this comment.
PHPStan emits:
Unsafe usage of new static().
See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
But fair enough, I'll remove those
Member
There was a problem hiding this comment.
ah, I see! Thats an intresting point. Maybe we should then use self instead. but please in a different PR if you want to solve it.
anyway it sounds odd to change the constructor and not the implementation of the static create method as it is just a syntax sugar to avoid the parenthesis around the new keyword: Option::create('h')->setDescription('Show help') instead of (new Option('h'))->setDescription('Show help')
tflori
reviewed
Jan 3, 2022
| * @return mixed | ||
| */ | ||
| public function offsetGet($offset) | ||
| public function offsetGet($offset): mixed |
Member
There was a problem hiding this comment.
mixed is not available in php 7 - is that a warning in php 8 now?
Member
There was a problem hiding this comment.
we have to go with that backward compatible comment
https://php.watch/versions/8.1/ReturnTypeWillChange
Author
I'm not able to run the tests in PHP 8.1, getting: But they run just fine in PHP 7.4: |
Member
|
indeed it is an open issue on gitlab repo: https://gitlab.com/gitlab-org/gitlab/-/issues/5667 |
Member
|
thx for your contribution. there is another PR to fix that issue and you forgot one of the final declarations. so I will go with that one. closed in favor of #173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes some errors reported by PHPStan