Repository navigation
Improvements on dataloader integration #13724
Description
Problem Statement
Following up: #13664
#13664 introduced basic support for dataloader integration on Sentry Node SDK.
In its current state, the feature set is limited, as there's no hook we can get request / lookup information from the underlying instrumentation @opentelemetry/instrumentation-dataloader.
More info on this: #13664 (comment)
Solution Brainstorm
We can open PRs on https://github.com/open-telemetry/opentelemetry-js-contrib/
- Adding a
requestHookorlookupHookto the OTEL instrumentation - Add instrumentations for
prime,clearandclearAlloperations indataloaderintegration. #13729
Activity
AbhiPrasad commentedon Sep 19, 2024
I think
requestHookwould be super useful, but luckily we can rely onbeforeSendSpanso it's not high priority.We should see if we can get the extra operations instrumented, and then also see if we can get additional attributes attached to these spans (that then we can use to enable these spans for our cache module).