Skip to content

SystemStackError exceptions dropped by payload truncation logic #1799

Description

@sl0thentr0py

These exceptions have lots of frames in the exception object, we could be a bit smarter and truncate the frames instead of dropping the whole envelope item.

Activity

  1. self-assigned this
    on Apr 27, 2022
  2. PikachuEXE commented on Apr 28, 2022

    @PikachuEXE
    Contributor

    Where is the payload truncation logic happening now?
    I can try to figure out what to change. (As this is affecting one of my projects)

  3. sl0thentr0py commented on Apr 28, 2022

    @sl0thentr0py
    MemberAuthor

    @PikachuEXE here

    if result.bytesize > Event::MAX_SERIALIZED_PAYLOAD_SIZE
    size_breakdown = item.payload.map do |key, value|
    "#{key}: #{JSON.generate(value).bytesize}"
    end.join(", ")
    log_debug("Envelope item [#{item.type}] is still oversized without breadcrumbs: {#{size_breakdown}}")
    next
    end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions