Repository navigation
CODEOWNERS documentation claims that a user needs at least read access, but GitHub's built in linter claims the user needs write access #18984
Description
Activity
@ScriptAutomate Thanks so much for opening an issue! I'll triage this for the team to take a look 👀
Thanks @ScriptAutomate, by coincidence this was actually just fixed internally and should be published shortly. 🙇🏻
Reacted by Derek Ardolf and ethanjang-nsuslabReacted by Derek ArdolfReacted by Derek ArdolfThanks!
For documentation purposes: It looks like the error was in the documentation, which has since been fixed. It does mean that only users with Write access can be used in the CODEOWNERS file.
New docs content:
The people you choose as code owners must have write permissions for the repository. When the code owner is a team, that team must be visible and it must have write permissions, even if all the individual members of the team already have write permissions directly, through organization membership, or through another team membership.
Is there a route I can take for a feature request? With our open source project, we would love to be able to have community members with explicit Read or Triage permissions to be able to be assigned to review PRs (since I thought that is what Triage was for??).
Reacted by ZitchasIt would be nice to able to have people who can not merge code (write), be apart of the review/notification/approval process for a PR.
Reacted by SeanRelated feature request has been opened:
ScriptAutomate has submitted the request, @lecoursen can you please ensure it has the correct labels. Many thanks.
👋🏻 @damon-atkins, the GitHub community discussions are owned by a different team. (We only own this repo and docs.github.com.) 💖 I'm sure the appropriate team will review the post shortly! 😊
I didn't realize there was an earlier feature request for the same thing, from back in 2019. That I'd add a backlink here:
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
What part(s) of the article would you like to see updated?
I read this as:
The GitHub linter throws a
This CODEOWNERS file contains errorsmessage, for my users with at least read access, and says:The problem is:
I can't tell whether the docs are wrong or the GitHub linter is wrong. This is why I'm raising this issue here.
Additional information
Example from PR:
Problems:
@ryan-laneexistsReadrole to the repositoryRead, at a minimum (thus alsoTriage), should be enough for individuals