You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Conclusion comment shows success when safe_outputs fails to submit PR review #30662
When the safe_outputs job fails to submit a PR review (e.g. GitHub API returns 422), the conclusion job still updates the PR comment with "✅ completed successfully!" because it only checks Agent Conclusion and Detection Conclusion, not whether safe outputs were actually delivered.
This makes it look like the reviewer ran and found nothing, when in reality it generated comments that failed to post.
Repro
Trigger an agentic workflow that uses safe-outputs with submit_pull_request_review
If the GitHub API returns a transient 422 error during PR review submission, the safe_outputs job logs ##[error] but the conclusion job still reports success
The conclusion job never checks the safe_outputs job result.
Expected behavior
The conclusion comment should show an error (e.g. ❌ or ⚠️) when safe_outputs fails to deliver its outputs, so the user knows to re-trigger the workflow.
Actual behavior
The comment shows "✅ completed successfully!" even though no review comments were posted to the PR.
Activity