Skip to content

feat: starttls and ldaps now matching features - #458

Merged
Fusion merged 2 commits into
masterfrom
feat/tls-improvement-by-hth2
Aug 4, 2025
Merged

Fusion merged 2 commits into
masterfrom
feat/tls-improvement-by-hth2

Conversation

@Fusion

@Fusion Fusion commented Aug 3, 2025

Copy link
Copy Markdown
Collaborator

This PR handles a few things:

  • application of the patch by @hth2, allowing LDAP to only accept secure ciphers and TLS >= 1.2
  • Alessandro's starttls introduction, 2 years ago (already?!)
  • fixing above patch as there was confusion between starttls and ldaps code
  • making sure both functionalities can be configured similarly
  • couple minor logic things
  • backward compatibility: cert and key configuration can now represent content, or file path (legacy)
  • backward compatibility: legacy configuration parameter, allowing all ciphers/TLS1.0 (but don't!)

@Fusion

Fusion commented Aug 3, 2025

Copy link
Copy Markdown
Collaborator Author

@shipperizer need review. Please confirm this does not break starttls for your use cases.

@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2025

Copy link
Copy Markdown

@shipperizer shipperizer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fusion
Fusion merged commit d68c78a into master Aug 4, 2025
@Fusion Fusion mentioned this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants