Skip to content

Selected speed option is not identified by TalkBack #10298

Closed

Description

@hshapley

ExoPlayer Version

2.17.1

Devices that reproduce the issue

All devices tested so far: Pixel 2 XL (Android 11), Pixel 4 (Android 12), OnePlus Nord CE 2 Lite

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Not tested

Reproduction steps

  1. Enable TalkBack on the device
  2. Open a video in ExoPlayer
  3. Open the controls and select Settings, then Speed
  4. Listen to the announced selection, and swipe through to "Normal"

Expected result

  • Normal should have focus by default
  • TalkBack should read "Normal - Selected" or "Normal - Checked"

Actual result

  • The lowest speed option has focus by default
  • When focus is moved to the selected option (Normal), it says "Normal - Double tap to activate". Which is incorrect, because it is already selected.

Media

https://www.sample-videos.com/video123/mp4/480/big_buck_bunny_480p_2mb.mp4

Bug Report

  • You will email the zip file produced by adb bugreport to [email protected] after filing this issue.

Activity

  1. self-assigned this
    on May 27, 2022
  2. christosts commented on May 27, 2022

    @christosts
    Contributor

    I can see this also occurs on the demo app. @icbaker will you able to take a look whether there is something in the UI elements that need to change?

  3. tonihei commented on Jul 15, 2022

    @tonihei
    Collaborator

    Fixed by the commit above.

  4. locked and limited conversation to collaborators on Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions