Skip to content

swift-button-functional-test job failing due to changes in sign in flow #367

Closed

Description

@mdmathias

The swift-button-functional-test job appears to no longer pass, likely due to changes in the sign in flow. I was able to get parts of the test case to pass, but not reliably. Running locally on a simulator, I would occasionally see the sign in flow succeed, and other times I would see a screen telling me that Safari was unable to contact the server.

Since this test is not passing, and is blocking the beta release of AppCheck support within GSI, I am going to disable this job. This is not harmful since this test is completely unrelated to AppCheck, and the AppCheck tests (including integration) are passing.

We should nonetheless follow up on this and fix the issue.

Activity

  1. added
    bugSomething isn't working
    triageIssues that need to be triaged
    on Feb 10, 2024
  2. self-assigned this
    on Feb 10, 2024
  3. mdmathias commented on Feb 10, 2024

    @mdmathias
    CollaboratorAuthor

    Need to make sure to re-enable this test and revert the if check back to if: "!github.event.pull_request.head.repo.fork".

  4. mdmathias commented on Oct 28, 2024

    @mdmathias
    CollaboratorAuthor

    Closed via #434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingtriageIssues that need to be triaged

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions