Skip to content
This repository was archived by the owner on Apr 18, 2026. It is now read-only.
This repository was archived by the owner on Apr 18, 2026. It is now read-only.

Unable to configure a proxy for the client #25

Closed
Closed
Unable to configure a proxy for the client#25
Assignees
jfschmakeit

Description

@wmorland
wmorland
opened on Dec 4, 2019

When creating HttpClients the code just calls HttpClientBuilder.create().build(); e.g.

java-photoslibrary/photoslibraryapi/src/main/java/com/google/photos/library/v1/upload/PhotosLibraryUploadCallable.java

Line 212 in 1ff3577

CloseableHttpClient httpClient = HttpClientBuilder.create().build();

This means that it is not possible to configure a proxy when using the PhotosLibraryClient and if this is required by the network setup it results in a java.net.SocketException: Network is unreachable (connect failed). The easiest fix would be to just call .useSystemProperties before calling .build on HttpClientBuilder and that would allow developers to specify a proxy using the System Properties.

Activity

  1. wmorland commented on Jan 16, 2020

    @wmorland
    wmorland
    on Jan 16, 2020
    ContributorAuthor

    Not sure who the best person to handle this is but would it be possible to publish a new release including this fix please? @Tmbao @katmle

  2. jfschmakeit
    self-assigned this
    on Jan 23, 2020

  3. wmorland commented on Apr 7, 2020

    @wmorland
    wmorland
    on Apr 7, 2020
    ContributorAuthor

    This is now available in release v1.5.0 https://github.com/google/java-photoslibrary/releases/tag/v1.5.0

    Thank you!

  4. wmorland
    closed this as completedon Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions