Skip to content
This repository was archived by the owner on Apr 18, 2026. It is now read-only.
This repository was archived by the owner on Apr 18, 2026. It is now read-only.

listMediaItems() method from PhotosLibraryClient.java returns duplicated entries #44

Description

@lina-grinchenko-sndk

It was discovered during integration with Google Photos using java-photoslibrary, please see its details

com.google.photos.library
google-photos-library-client
1.7.0

For example, real test account has 468 files in Photos App, although Photos library returns 476 files. When the real list of files on Google Photos was compared with the list of files returned by PhotosLibraryClient.listMediaItems(), appeared that 8 files had duplicates, although there were no duplicates in Photos App.

To handle this issue on our side, we just wrapped result of PhotosLibraryClient.listMediaItems() to Set, although it'd be useful to see any comments about it in documentation, if it is expected, or have a fix for this issue.

Let me know if you need any additional info on it.

Thanks.

Activity

  1. nikhil6624 commented on Sep 7, 2022

    @nikhil6624

    @Grinchenkolina , May I work on this issue? I found the potential root cause of this issue.

  2. lina-grinchenko-sndk commented on Sep 7, 2022

    @lina-grinchenko-sndk
    Author

    @nikhil6624, it'll be good to have this issue fixed, thanks.

  3. nikhil6624 commented on Sep 7, 2022

    @nikhil6624

    I'll start working on it @Grinchenkolina . :)
    I have submitted the CLA as well by visiting https://cla.developers.google.com/.

  4. nikhil6624 commented on Oct 30, 2022

    @nikhil6624

    @Grinchenkolina , I have resolved this issue. Which branch should I choose to push those changes to? Also I'm UNABLE to create a new branch for this issue fix so that I can raise a pull request from that branch. Could you please help me create a branch for pushing those fixes??
    image

  5. nikhil6624 commented on Oct 30, 2022

    @nikhil6624

    @Grinchenkolina , Here's the error I'm getting when I use the Git command line for created a remote tracking branch,
    image

  6. lina-grinchenko-sndk commented on Oct 31, 2022

    @lina-grinchenko-sndk
    Author

    Hi @nikhil6624, the matter is that I'm not a contributor of this repo. I'm a user of this library who faced this issue.

  7. nikhil6624 commented on Dec 7, 2022

    @nikhil6624

    @jfschmakeit , could you please give me access to commit to this repo? I have fixed this issue. The issue is actually in the demos project, which uses the photos library client to demonstrate the usage of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions