Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

ignore labels unless it is an object - #352

Merged
ofrobots merged 1 commit into
googleapis:masterfrom
ofrobots:labels-must-be-object
Jan 20, 2017
Merged

ignore labels unless it is an object#352
ofrobots merged 1 commit into
googleapis:masterfrom
ofrobots:labels-must-be-object

Conversation

@ofrobots

@ofrobots ofrobots commented Jan 19, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 19, 2017
@ofrobots
ofrobots force-pushed the labels-must-be-object branch from 9e54c5f to 25e1b23 Compare January 19, 2017 23:31
matthewloring
matthewloring suggested changes Jan 19, 2017
View reviewed changes
Comment thread package.json
"@google-cloud/common": "^0.11.0",
"continuation-local-storage": "^3.1.4",
"gcp-metadata": "^0.1.0",
"is": "^3.2.0",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread test/standalone/test-index.js Outdated
var traceSpan = spanData.span;
assert.equal(traceSpan.name, 'sub');
assert.ok(traceSpan.labels);
assert.strictEqual(traceSpan.labels[0], undefined);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread test/standalone/test-index.js Outdated
agent.start();
cls.getNamespace().run(function() {
agent.private_().createRootSpanData('root', 1, 2);
var stringWithProperty = 'foo';

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ofrobots
ofrobots force-pushed the labels-must-be-object branch from 25e1b23 to c626eca Compare January 20, 2017 00:15
@ofrobots
ofrobots force-pushed the labels-must-be-object branch from c626eca to 85aa7c9 Compare January 20, 2017 00:29
@ofrobots
ofrobots merged commit 8b05415 into googleapis:master Jan 20, 2017
@ofrobots
ofrobots deleted the labels-must-be-object branch January 20, 2017 00:40
@ofrobots ofrobots mentioned this pull request Jan 21, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@AdriVanHoudt AdriVanHoudt AdriVanHoudt left review comments
@matthewloring matthewloring matthewloring approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ofrobots @matthewloring @AdriVanHoudt @googlebot