Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Fix flaky FlowControllerTest #1359

Closed
Closed

Description

@vam-google

The FlowControllerTest#testConcurrentUpdateThresholds_nonBlocking seems to be very flaky. It also failed the release of gax 1.63.2 (#1357).

The buidl very often fails with an error like the following:

com.google.api.gax.batching.FlowControllerTest > testConcurrentUpdateThresholds_nonBlocking FAILED
    The maximum number of batch elements: 4850 have been reached.
        at com.google.api.gax.batching.FlowController.reserve(FlowController.java:221)
        at com.google.api.gax.batching.FlowControllerTest.testRejectedReserveRelease(FlowControllerTest.java:503)
        at com.google.api.gax.batching.FlowControllerTest.testConcurrentUpdateThresholds_nonBlocking(FlowControllerTest.java:570)

Activity

  1. vam-google commented on May 1, 2021

    @vam-google
    ContributorAuthor
  2. added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on May 10, 2021
  3. vam-google commented on May 10, 2021

    @vam-google
    ContributorAuthor

    This has been fixed by @mutianf in #1365. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions