This repository was archived by the owner on Nov 18, 2025. It is now read-only.
Repository navigation
refactor: relicense google-gax as Apache 2.0 - #704
Merged
Merged
Conversation
alexander-fenster
requested review from
JustinBeckwith,
bcoe and
xiaozhenliu-gg5
January 8, 2020 00:51
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
- Coverage 90% 89.43% -0.57%
==========================================
Files 44 44
Lines 7845 7282 -563
Branches 414 414
==========================================
- Hits 7061 6513 -548
+ Misses 781 766 -15
Partials 3 3
Continue to review full report at Codecov.
|
bcoe
approved these changes
Jan 8, 2020
| /* | ||
| * Copyright 2019 Google LLC | ||
| * All rights reserved. | ||
| /** |
There was a problem hiding this comment.
we've been using // comments for licenses, but if it's a hassle to make this change not a blocker for me.
Contributor
Author
There was a problem hiding this comment.
So... I first removed all the licenses using some Perl magic, then used https://github.com/google/addlicense to add them. Turns out it uses /** */ style licenses, I guess it should be fine.
xiaozhenliu-gg5
approved these changes
Jan 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package is the only googleapis Node.js package that is BSD-licensed. Since we've got approval to relicense it as Apache 2.0, let's just do it so that it matches the other packages and so that our tools and bots are happy.