Repository navigation
feat(channel): generate library - #8116
Conversation
product-auto-label
Bot
added
the
api: cloudchannel
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8116 +/- ##
==========================================
- Coverage 94.59% 94.58% -0.01%
==========================================
Files 1320 1320
Lines 117792 117792
==========================================
- Hits 111421 111415 -6
- Misses 6371 6377 +6
Continue to review full report at Codecov.
|
| "google/cloud/bigtable/internal/readrowsparser_acceptance_tests.inc", | ||
| # The source proto files have one or more typos in their comments | ||
| "google/cloud/accessapproval/access_approval_client.h", | ||
| "google/cloud/channel/cloud_channel_client.h", |
There was a problem hiding this comment.
Consider sending CLs to fix the typos upstream, I just merged my fixes for storage_transfer_client.h
There was a problem hiding this comment.
It's not clear that it's a real typo. It complained about "add-ons" (the ons part). Maybe it's a typos bug. Not sure. In a way, it may be good to teach typos to ignore all auto-generated libraries.
There was a problem hiding this comment.
The comments go straight to our Doxygen documentation. The number of typos is small, but I would rather not ignore them and fix the problems upstream. Less embarrassing for everyone involved. It would be nice if the protos in googleapis/googleapis used some kind of typo detector too.
There was a problem hiding this comment.
Makes sense. I'll keep that in mind. In this case, typos complained about "Add-ons", which I think is spelled correctly; it's likely a bug in typos.
There was a problem hiding this comment.
Can't we add an extend-words entry to our .typos.toml file?
There was a problem hiding this comment.
Generally, we could do that. In this case, however, the typo is actually "ons" from the word "add-ons". So if we used extend-words we'd have to teach it that "ons" is a valid word, which is generally not true. Extending the allowed words to allow "add-ons" does not work.
FTR, the actual output was:
--> ./google/cloud/channel/cloud_channel_client.h:813:10
|
813 | /// add-ons, or entitlements for Google Cloud's development platform.
| ^^^
|
... 0.784 seconds
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
80bacc8 to
70d45b4
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
4 participants
Fixes: #8115
This change is