Repository navigation
Generate insertId if not provided. - #2739
Merged
Merged
Conversation
Contributor
|
@tswast based on some dialog within the attached issue, it seems like a uuid per row might not be the way to go. Would you mind taking a peak at this? |
Contributor
|
UUID-per-row is the way to go (if the user does not provide one). After some discussion with the BigQuery team, we determined that a row ID should always be included in the request. If not present, create a unique ID for the row through a suitably random source. The reason behind this is so that the API request can safely be retried by the client library. |
Contributor
|
Awesome, thanks for the feedback! |
callmehiphop
approved these changes
Nov 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1041