Skip to content

chore(config): consolidate mocharc monorepo - #8415

Merged
feywind merged 13 commits into
googleapis:mainfrom
quirogas:chore/consolidate-mocharc-monorepo
Jun 3, 2026
Merged

feywind merged 13 commits into
googleapis:mainfrom
quirogas:chore/consolidate-mocharc-monorepo

Conversation

@quirogas

@quirogas quirogas commented Jun 2, 2026 •

Copy link
Copy Markdown
Contributor

Consolidates monorepo-wide Mocha configuration into a single unified .mocharc.cjs file at the workspace root. It also cleans up all duplicate package-level configs, implements a shared platform-independent generic batch test runner (ci/run_mocha_batches.cjs) for large test suites, and sets the CI memory ceiling to 6GB.

For #librarian/4583

quirogas added 2 commits June 2, 2026 12:00
…i test runner memory limits, and remove all duplicate package-level configs
@quirogas quirogas self-assigned this Jun 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consolidates Mocha test configurations across the monorepo by removing duplicate local configuration files and updating baseline package scripts to reference the root .mocharc.js file. It also enables parallel test execution in the root configuration and increases the Node.js memory limit in the CI script. Feedback highlights that removing "recursive": true from the root Mocha configuration could cause nested tests to be silently skipped, and increasing the memory limit to 8GB in the CI script exceeds standard GitHub runner limits, potentially causing OOM crashes.

Comment thread .mocharc.js Outdated
Comment thread ci/run_single_test.sh Outdated
@quirogas
quirogas marked this pull request as ready for review June 3, 2026 18:22
@quirogas
quirogas requested a review from a team as a code owner June 3, 2026 18:22
@feywind
feywind merged commit d2c491f into googleapis:main Jun 3, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants