Skip to content

chore: remove stale google/cloud/common_resources.proto copies - #8457

Merged
jskeet merged 2 commits into
googleapis:mainfrom
jskeet:remove-stale-protos
Jun 9, 2026
Merged

jskeet merged 2 commits into
googleapis:mainfrom
jskeet:remove-stale-protos

Conversation

@jskeet

@jskeet jskeet commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

These are not needed, and won't be included after the Librarian generation. Removing them ahead of time will reduce the diff during Librarian migration.

These are not needed, and won't be included after the Librarian
generation. Removing them ahead of time will reduce the diff during
Librarian migration.
@jskeet
jskeet requested a review from quirogas June 9, 2026 06:19
@jskeet
jskeet requested a review from a team as a code owner June 9, 2026 06:19

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deletes the protobuf definitions for common Google Cloud Platform (GCP) resources, including Project, Organization, Folder, BillingAccount, and Location. There are no review comments, and I have no feedback to provide.

@jskeet
jskeet force-pushed the remove-stale-protos branch 2 times, most recently from d6911ca to 4226249 Compare June 9, 2026 07:19
@quirogas quirogas mentioned this pull request Jun 9, 2026
@jskeet
jskeet merged commit f3cc67c into googleapis:main Jun 9, 2026
32 checks passed
@jskeet
jskeet deleted the remove-stale-protos branch June 9, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants