Repository navigation
fix(storage): re-throw upload error after aborting in uploadFileInChunks - #9566
Open
thiyaguk09 wants to merge 2 commits into
Open
thiyaguk09 wants to merge 2 commits into
thiyaguk09 wants to merge 2 commits into
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the error handling in TransferManager during multipart upload failures, ensuring that if aborting the upload also fails, a MultiPartUploadError combining both the original error and the abort error is thrown. Unit tests have been updated and added to verify this behavior. Feedback suggests a more defensive approach to extracting error messages from the caught exceptions to avoid potential runtime TypeErrors if the thrown values are not standard Error objects.
…to handle non-Error objects
thiyaguk09
marked this pull request as ready for review
October 8, 2026 13:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensures
TransferManager.uploadFileInChunksalways rejects with aMultiPartUploadErrorwhen a multipart upload fails, even when automatic cleanup (abortUpload) succeeds.Impact
Prevents silent data loss where failed chunked uploads previously resolved to
undefinedafter aborting the multipart upload, misleading callers into assuming the file upload succeeded.Changes
return;statement inuploadFileInChunksaftermpuHelper.abortUpload()succeeds so that the original upload error is thrown as aMultiPartUploadError.mpuHelper.abortUpload()also fails.Testing
abortUploadunit test intest/transfer-manager.tsto assert thatuploadFileInChunksrejects with the original upload error whenabortUploadsucceeds.test/transfer-manager.tsverifying that when bothuploadPartandabortUploadfail, the rejectedMultiPartUploadErrorincludes both error messages.Fixes #9193