refactor!: Remove RefreshOptions type in OAuth2Client #7733

Activity

1. danielbankhead

   added

   type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.

   semver: majorHint for users that this is an API breaking change.Hint for users that this is an API breaking change.

   good first issueThis issue is a good place to started contributing to this repository.This issue is a good place to started contributing to this repository.

   priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.

   next major: breaking changethis is a change that we should wait to bundle into the next major versionthis is a change that we should wait to bundle into the next major version

   on Oct 12, 2023
2. danielbankhead

   changed the title [-]refactor!: Remove `RefreshOptions` type in OAuth2Client[/-] [+]refactor!: Remove `RefreshOptions` type in `OAuth2Client`[/+] on Oct 12, 2023
3. milinddethe15 commented on Oct 13, 2023

   

   milinddethe15

   on Oct 13, 2023

   More actions

   Hi @danielbankhead, I would like to work on this. If I understood the issue, I just have to remove extends RefreshOptions from

   export interface OAuth2ClientOptions extends RefreshOptions {
     clientId?: string;
     clientSecret?: string;
     redirectUri?: string;
     credentials?: Credentials;
   }
   
4. danielbankhead commented on Oct 13, 2023

   

   danielbankhead

   on Oct 13, 2023

   ContributorAuthor

   More actions

   Hey @milinddethe15, good question - after googleapis/google-auth-library-nodejs#1663 has been merged the RefreshOptions interface itself can be removed.
5. danieljbruce

   assigned

   danielbankhead

   on Oct 13, 2023
6. danielbankhead

   removed their assignment

   on Oct 13, 2023
7. milinddethe15 commented on Oct 13, 2023

   

   milinddethe15

   on Oct 13, 2023

   More actions

   Hi, I want to work on this issue. Assign me.
8. danielbankhead

   assigned

   milinddethe15

   on Oct 13, 2023
9. danielbankhead commented on Oct 13, 2023

   

   danielbankhead

   on Oct 13, 2023

   Last edited by danielbankhead

   ContributorAuthor

   More actions

   @milinddethe15 done! Take your time as this refactor is a breaking change and we won’t release another major for some time.
10. d-goog

    assigned

    d-goog

    and unassigned

    milinddethe15

    on Feb 21, 2025
11. GautamSharda

    added

    good first issueThis issue is a good place to started contributing to this repository.This issue is a good place to started contributing to this repository.

    type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.

    priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.

    semver: majorHint for users that this is an API breaking change.Hint for users that this is an API breaking change.

    next major: breaking changethis is a change that we should wait to bundle into the next major versionthis is a change that we should wait to bundle into the next major version

    on Nov 3, 2025
12. GautamSharda

    transferred this issue fromgoogleapis/google-auth-library-nodejson Nov 3, 2025
13. sofisl

    added

    library: google-cloud-node-coreIssues transferred from another repositoryIssues transferred from another repository

    on Mar 18, 2026
14. sofisl

    transferred this issue fromgoogleapis/google-cloud-node-coreon Mar 18, 2026