Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

bad generated param name function_Param #574

Closed

Description

@chingor13

https://github.com/googleapis/nodejs-functions/pull/146/files#diff-befd2ad0da13326aa9d2b9089e57ae16a5fa61ac16c2bd566035f10d46ff6e5dR1701

It's being generated as:

  cloudFunctionPath(project: string, location: string, functionParam: string) {
    return this.pathTemplates.cloudFunctionPathTemplate.render({
      project: project,
      location: location,
      function: function_Param, // this one is incorrect
    });
  }

Activity

  1. added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Mar 21, 2022
  2. summer-ji-eng commented on Mar 21, 2022

    @summer-ji-eng
    Contributor

    Weird. It should be a camel case. id.get(param.toCamelCase()) template code
    And it works for nodejs-speech PR and nodejs-service-center PR. These two both have the reserved words like package and export.

    I generated for nodejs-function locally, and it works with functionParam.
    image

    Will manual update for nodejs-function with owlbot.

  3. summer-ji-eng commented on Mar 21, 2022

    @summer-ji-eng
    Contributor

    @chingor13 owlbot.py keep the _. Let me remove the hacks in owlbot.py.

  4. summer-ji-eng commented on Mar 22, 2022

    @summer-ji-eng
    Contributor

    Not generator issue.

    Updated the PR in nodejs-functions. googleapis/nodejs-functions@c21c97e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions