Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

bug: wrong client name in the system test fixture for bigquery-storage #589

Closed
Closed
bug: wrong client name in the system test fixture for bigquery-storage#589
Assignees
summer-ji-eng
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@tmatsuo
tmatsuo
opened on Sep 23, 2021

The PR in question:

googleapis/nodejs-bigquery-storage#209

The files from owl-bot are:

https://github.com/googleapis/nodejs-bigquery-storage/blob/48e92f43ea60ee20ca6e460ec59d74b458665406/system-test/fixtures/sample/src/index.ts

and

https://github.com/googleapis/nodejs-bigquery-storage/blob/48e92f43ea60ee20ca6e460ec59d74b458665406/system-test/fixtures/sample/src/index.js

You can see both files are using BigQueryWriteClient, but this is not the correct name, so the system tests failed.

I manually changed them to BigQueryStorageClient and now the system tests is passing.

Activity

  1. tmatsuo
    added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Sep 23, 2021

  2. summer-ji-eng commented on Oct 4, 2021

    @summer-ji-eng
    summer-ji-eng
    on Oct 4, 2021
    Contributor

    Interesting. Thanks for the manual change to unblock API.
    I will take a look in October.

  3. summer-ji-eng
    self-assigned this
    on Oct 4, 2021
  4. yoshi-automation
    added
    🚨This issue needs some love.
    and removed
    🚨This issue needs some love.
    on Jan 2, 2022

  5. summer-ji-eng commented on Jan 7, 2022

    @summer-ji-eng
    summer-ji-eng
    on Jan 7, 2022
    Contributor

    In v1 storage.proto, 2 services:

    And looks like the system-test use BigQueryWriteClient back (code).

    Close for now. If you have question, feel free to open it up. Thank you very much.

  6. summer-ji-eng
    closed this as completedon Jan 7, 2022
  7. miguelvelezsa
    transferred this issue fromgoogleapis/gapic-generator-typescripton Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions