Skip to content
This repository was archived by the owner on Mar 19, 2026. It is now read-only.
This repository was archived by the owner on Mar 19, 2026. It is now read-only.

Fix errors missing from ads nodejs GAPIC lib #617

Closed
googleapis/gapic-generator-typescript
#878
Closed
Fix errors missing from ads nodejs GAPIC lib#617
googleapis/gapic-generator-typescript
#878
Assignees
summer-ji-eng
Labels
priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@summer-ji-eng
summer-ji-eng
opened on May 18, 2021

gapic-generator-typescript eliminate errors.protos from the JSON lists when generate googleads-nodejs from google/ads/{version}/*protos. This happened in generator version > 1.3.0.

The protos in googleads//errors, there is no service. That's why with change on googleapis/gapic-generator-typescript#847, the errors has removed.

Activity

  1. summer-ji-eng
    added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on May 18, 2021
  2. summer-ji-eng
    self-assigned this
    on May 18, 2021
  3. yoshi-automation
    added
    🚨This issue needs some love.
    and removed
    🚨This issue needs some love.
    on May 24, 2021
  4. alexander-fenster
    closed this as completedin gapic-generator-typescript#878on May 24, 2021

  5. summer-ji-eng commented on May 25, 2021

    @summer-ji-eng
    summer-ji-eng
    on May 25, 2021
    ContributorAuthor

    Released with version 1.4.0

  6. miguelvelezsa
    added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on Nov 4, 2025
  7. miguelvelezsa
    transferred this issue fromgoogleapis/gapic-generator-typescripton Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions