Skip to content

HttpBackOffIOExceptionHandler and HttpBackOffUnsuccessfulResponseHandler do not restore the interrupted status after catching InterruptionException #1005

Closed
#1006
Closed
HttpBackOffIOExceptionHandler and HttpBackOffUnsuccessfulResponseHandler do not restore the interrupted status after catching InterruptionException#1005
#1006
Assignees
chingor13
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@micheldavid
micheldavid
opened on Mar 20, 2020

I found this by accident while looking at a different unexpected behavior within my system.

google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/HttpBackOffIOExceptionHandler.java

Line 100 in 8760ff0

return false;

While handling IOException, the HttpBackOffIOExceptionHandler does not rethrow an exception and also does not reset the thread interrupted bit after catching InterruptedException.

See article with explanation: https://dzone.com/articles/why-do-we-need-threadcurrentthreadinterrupt-in-int

Environment details

  1. Specify the API: GCS objects list
  2. OS type and version: Debian
  3. Java version: Java 8
  4. google-http-client version(s): 1.34.2

Activity

  1. micheldavid
    added a commit that references this issue on Mar 20, 2020

    fix: reset the thread's interrupt bit after catching InterruptedExcep…

    1ae169e
  2. yoshi-automation
    added
    triage meI really want to be triaged.
    🚨This issue needs some love.
    on Mar 20, 2020
  3. chingor13
    added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Mar 25, 2020
  4. yoshi-automation
    removed
    🚨This issue needs some love.
    triage meI really want to be triaged.
    on Mar 25, 2020
  5. micheldavid
    added a commit that references this issue on Jun 18, 2020

    fix: reset the thread's interrupt bit after catching InterruptedExcep…

    e3a2040
  6. micheldavid
    changed the title [-]HttpBackOffIOExceptionHandler does not reset the interrupt bit after catching InterruptionException[/-] [+]HttpBackOffIOExceptionHandler and HttpBackOffUnsuccessfulResponseHandler do not restore the interrupted status after catching InterruptionException[/+] on Jun 18, 2020
  7. chingor13
    closed this as completedin #1006on Jun 19, 2020
  8. chingor13
    added a commit that references this issue on Jun 19, 2020

    fix: restore the thread's interrupted status after catching Interrupt…

    0a73a46
  9. gcf-merge-on-green
    added a commit that references this issue on Jul 1, 2020

    chore: release 1.36.0 (#1073)

    8ea3348
  10. JustinBeckwith
    assigned
    chingor13
    on Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions