Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

docs(sample): Use Java 8 for native image sample - #893

Merged
mpeddada1 merged 5 commits into
mainfrom
fix-native-sample
Mar 1, 2022
Merged

mpeddada1 merged 5 commits into
mainfrom
fix-native-sample

Conversation

@mpeddada1

Copy link
Copy Markdown
Contributor

This should fix the Native Image sample which is failing with the following error:

Screen Shot 2022-03-01 at 5 02 36 PM

@mpeddada1
mpeddada1 requested review from a team March 1, 2022 22:03
@product-auto-label product-auto-label Bot added api: firestore Issues related to the googleapis/java-firestore API. samples Issues that are directly related to samples. labels Mar 1, 2022

@suztomo suztomo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix

              <mainClass>com.example.firestore.NativeImageFirestoreSample
              </mainClass>

to

              <mainClass>com.example.firestore.NativeImageFirestoreSample</mainClass>

@suztomo suztomo changed the title fix(java): Use Java 8 for native image sample docs(sample): Use Java 8 for native image sample Mar 1, 2022
@suztomo

suztomo commented Mar 1, 2022 •

Copy link
Copy Markdown
Member

I updated the title to reflect that the fix is not for the library users.

@mpeddada1 mpeddada1 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 1, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 1, 2022
@mpeddada1
mpeddada1 merged commit 5955f54 into main Mar 1, 2022
@mpeddada1
mpeddada1 deleted the fix-native-sample branch March 1, 2022 23:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/java-firestore API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants