Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

fix: Better error message when Transaction/WriteBatch is modified after commit. - #1503

Merged
ehsannas merged 3 commits into
mainfrom
ehsann/better-error-message
Dec 15, 2023
Merged

ehsannas merged 3 commits into
mainfrom
ehsann/better-error-message

Conversation

@ehsannas

Copy link
Copy Markdown
Contributor

Fixes #1183

@ehsannas
ehsannas requested a review from a team December 12, 2023 16:16
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/java-firestore API. labels Dec 12, 2023
@ehsannas
ehsannas requested a review from milaGGL December 12, 2023 16:52

@milaGGL milaGGL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milaGGL milaGGL assigned ehsannas and unassigned milaGGL Dec 13, 2023
@ehsannas
ehsannas requested a review from a team December 15, 2023 15:08
@ehsannas
ehsannas merged commit 9693c7b into main Dec 15, 2023
@ehsannas
ehsannas deleted the ehsann/better-error-message branch December 15, 2023 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong Exception Message in Transactions

2 participants