Skip to content
This repository was archived by the owner on Sep 25, 2026. It is now read-only.
This repository was archived by the owner on Sep 25, 2026. It is now read-only.

Need a test framework for Storage RPC tests #450

Closed

Description

@dmitry-fa

Google requires to cover all new code and all changes in the code by tests. The majority of the Storage code is covered by unit tests, but not com.google.cloud.storage.spi.v1.HttpStorageRpc. Testing of HttpStorageRpc is a bit tricky, so having a framework allowing us to write laconic tests for RPC would help to meet the Google requirements.

// cc @frankyn

Activity

  1. self-assigned this
    on Aug 4, 2020
  2. added
    type: cleanupAn internal cleanup or hygiene concern.
    and removed
    triage meI really want to be triaged.
    on Aug 5, 2020
  3. BenWhitehead commented on Aug 5, 2022

    @BenWhitehead
    Collaborator

    As of today, the majority of retry related (ITRetryConformanceTest.java) and option mapping related behavior validation (ITOptionRegressionTest.java) are covered by other tests. As such, we're not going to spend time to develop a test framework for only HttpStorageRpc. Instead we will focus on testing the higher level Models and Storage implementations which we steer our customers toward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: storageIssues related to the googleapis/java-storage API.type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions