Skip to content
This repository was archived by the owner on Sep 25, 2026. It is now read-only.

fix: cherry pick #1160 - #1254

Merged
frankyn merged 1 commit into
1.113.14-spfrom
cherypick-sp
Feb 15, 2022
Merged

frankyn merged 1 commit into
1.113.14-spfrom
cherypick-sp

Conversation

@frankyn

@frankyn frankyn commented Feb 15, 2022 •

Copy link
Copy Markdown
Contributor
  • fix: Remove all client side validation for OLM, allow nonspecific lifecycle actions

#1160)

* fix: Remove all client side validation for OLM, allow nonspecific lifecycle actions

* Test unsupported actions

* address comments

* Fix clirr

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* checkstyle

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/java-storage API. label Feb 15, 2022
@frankyn
frankyn marked this pull request as ready for review February 15, 2022 19:34
@frankyn
frankyn requested a review from a team February 15, 2022 19:34
@codecov

codecov Bot commented Feb 15, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #1254 (fe64db3) into 1.113.14-sp (2084a23) will increase coverage by 0.13%.
The diff coverage is 90.90%.

Impacted file tree graph

@@                Coverage Diff                @@
##             1.113.14-sp    #1254      +/-   ##
=================================================
+ Coverage          64.43%   64.56%   +0.13%     
+ Complexity           642      633       -9     
=================================================
  Files                 32       32              
  Lines               5336     5342       +6     
  Branches             526      527       +1     
=================================================
+ Hits                3438     3449      +11     
+ Misses              1733     1729       -4     
+ Partials             165      164       -1     
Impacted Files Coverage Δ
...main/java/com/google/cloud/storage/BucketInfo.java 84.41% <90.90%> (+0.44%) ⬆️
...gle/cloud/storage/testing/RemoteStorageHelper.java 64.00% <0.00%> (+2.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2084a23...fe64db3. Read the comment docs.

@BenWhitehead BenWhitehead changed the title chore: cherry pick 1160 fix: cherry pick #1160 Feb 15, 2022
@frankyn
frankyn merged commit 7253ad6 into 1.113.14-sp Feb 15, 2022
@frankyn
frankyn deleted the cherypick-sp branch February 15, 2022 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/java-storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants