This repository was archived by the owner on Feb 7, 2026. It is now read-only.
Repository navigation
docs: change properties with function value to methods - #1047
Merged
Merged
Conversation
google-cla
Bot
added
the
cla: yes
product-auto-label
Bot
added
the
api: bigquery
fhinkel
changed the title
fhinkel
force-pushed
the
fhinkel-imports
branch
3 times, most recently
from
November 24, 2021 18:33
7748635 to
31ca48a
Compare
fhinkel
force-pushed
the
fhinkel-imports
branch
2 times, most recently
from
November 24, 2021 19:07
4a448cf to
e6955a4
Compare
fhinkel
force-pushed
the
fhinkel-imports
branch
from
November 24, 2021 19:08
e6955a4 to
ced4a53
Compare
tswast
reviewed
Nov 29, 2021
| * @param {?error} callback.err An error returned while making this request. | ||
| * @param {Job} callback.job The newly created job. | ||
| * @param {object} callback.apiResponse The full API response. | ||
| * @returns {Promise<JobResponse>} |
Contributor
There was a problem hiding this comment.
I assume this was removed because it's now part of a type annotation?
| * A geography value represents a surface area on the Earth | ||
| * in Well-known Text (WKT) format. | ||
| * | ||
| * @method BigQuery.geography |
Contributor
There was a problem hiding this comment.
I assume this was removed because it's documented at the actual method definition now?
Contributor
Author
There was a problem hiding this comment.
Yes, it's redundant with TSDoc.
steffnay
approved these changes
Dec 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See microsoft/rushstack#3031
Internally, see b/206943288
Drive-by fix: