This repository was archived by the owner on Mar 19, 2026. It is now read-only.
Repository navigation
ts: Genericize CreateOptions in ServiceObject - #275
Merged
Merged
Conversation
googlebot
added
the
cla: yes
jkwlui
self-requested a review
October 22, 2018 20:44
ghost
assigned
jkwlui
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
jkwlui
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
jkwlui
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
jkwlui
approved these changes
Oct 31, 2018
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
=========================================
Coverage ? 98.48%
=========================================
Files ? 10
Lines ? 2043
Branches ? 119
=========================================
Hits ? 2012
Misses ? 18
Partials ? 13
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #263