Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

TypeScript: CreateZoneRequest property dnsName should be required #309

Description

@carnesen

As it stands, the property dnsName is not required in type CreateZoneRequest

nodejs-dns/src/index.ts

Lines 54 to 58 in 998c65e

export interface CreateZoneRequest {
dnsName?: string;
description?: string;
name?: string;
}

That property is required at runtime:

nodejs-dns/src/index.ts

Lines 250 to 252 in 998c65e

if (!config || !config.dnsName) {
throw new Error('A zone dnsName is required.');
}

and therefore should be required in the type.

Activity

  1. added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    and removed
    triage meI really want to be triaged.
    on Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

🚨This issue needs some love.TypeScriptapi: dnsIssues related to the googleapis/nodejs-dns API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions