Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.
This repository was archived by the owner on May 6, 2026. It is now read-only.

Imports incompatible with TypeScript #155

Closed
Closed
Imports incompatible with TypeScript#155
Assignees
ofrobots
Labels
🚨This issue needs some love.api: clouderrorreportingIssues related to the googleapis/nodejs-error-reporting API.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@laurentpellegrino
laurentpellegrino
opened on Jun 29, 2018

I am using this library with Firebase functions written in TypeScript. Since I upgraded to version 0.5.0 I am getting the following error from tslint:

node_modules/@google-cloud/error-reporting/node_modules/@google-cloud/common/build/src/service-object.d.ts:18:8 - error TS1192: Module '"/home/lpellegr/X/functions/node_modules/@types/request/index"' has no default export.

18 import r from 'request';
~

node_modules/@google-cloud/error-reporting/node_modules/@google-cloud/common/build/src/service.d.ts:17:8 - error TS1192: Module '"/home/lpellegr/X/functions/node_modules/@types/request/index"' has no default export.

17 import r from 'request';
~

node_modules/@google-cloud/error-reporting/node_modules/@google-cloud/common/build/src/util.d.ts:20:8 - error TS1192: Module '"/home/lpellegr/X/functions/node_modules/@types/duplexify/index"' has no default export.

20 import duplexify from 'duplexify';
~~~~~~~~~

node_modules/@google-cloud/error-reporting/node_modules/@google-cloud/common/build/src/util.d.ts:23:8 - error TS1192: Module '"/home/lpellegr/X/functions/node_modules/@types/request/index"' has no default export.

23 import r from 'request';

There were no issues with version 0.4.0. TypeScript 2.9.2 is used.

Activity

  1. ofrobots
    added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on Jun 29, 2018

  2. ofrobots commented on Jun 29, 2018

    @ofrobots
    ofrobots
    on Jun 29, 2018
    Contributor

    @lpellegr thanks for the report. I think this problem is due to one of our dependencies (@google-cloud/common) using the new allowSyntheticImports feature in TypeScript which leaks through to the users 😰.

    I think this has already been fixed upstream, and picking up a new release of the library will fix the problem.

    I believe this will go away with a new release of @google-cloud/logging is done and we pick that up here.

  3. ofrobots
    added
    status: blockedResolving the issue is dependent on other work.
    on Jun 29, 2018
  4. JustinBeckwith
    added
    triage meI really want to be triaged.
    on Jun 30, 2018

  5. ofrobots commented on Jun 30, 2018

    @ofrobots
    ofrobots
    on Jun 30, 2018
    Contributor

    Blocked on googleapis/nodejs-logging#149.

  6. JustinBeckwith
    added
    🚨This issue needs some love.
    on Jul 4, 2018
  7. ofrobots
    added a commit that references this issue on Jul 7, 2018

    fix: upgrade to @google-cloud/[email protected]

    bd2b68e
  8. ofrobots
    removed
    status: blockedResolving the issue is dependent on other work.
    on Jul 7, 2018
  9. ofrobots
    self-assigned this
    on Jul 7, 2018
  10. JustinBeckwith
    removed
    triage meI really want to be triaged.
    🚨This issue needs some love.
    on Jul 7, 2018

  11. ofrobots commented on Jul 7, 2018

    @ofrobots
    ofrobots
    on Jul 7, 2018
    Contributor

    Fix over in #158.

    I was confusing this issue with another one in @google-cloud/logging-winston. This did not depend on googleapis/nodejs-logging#149.

  12. ofrobots
    closed this as completedin #158on Jul 7, 2018
  13. ofrobots
    added a commit that references this issue on Jul 7, 2018

    fix: upgrade to @google-cloud/[email protected] (#158)

    8053a41
  14. ghost removed
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on Jul 7, 2018

  15. ofrobots commented on Jul 10, 2018

    @ofrobots
    ofrobots
    on Jul 10, 2018
    Contributor

    @lpellegr 0.5.1 has been release which should no longer have this issue. Please give this a shot and re-open or comment here if you're still running into issues.

  16. gcf-label-sync
    added
    api: clouderrorreportingIssues related to the googleapis/nodejs-error-reporting API.
    on Jan 31, 2020
  17. yoshi-automation
    added
    triage meI really want to be triaged.
    🚨This issue needs some love.
    on Apr 7, 2020
  18. GautamSharda
    added 2 commits that reference this issue on Jan 14, 2026

    fix: upgrade to @google-cloud/[email protected] (#158)

    3d27b0b

    fix: upgrade to @google-cloud/[email protected] (#158)

    83e85da
  19. GautamSharda
    added a commit that references this issue on Feb 5, 2026

    fix: upgrade to @google-cloud/[email protected] (#158)

    0c94bd0
  20. GautamSharda
    added 2 commits that reference this issue on Feb 23, 2026

    fix: upgrade to @google-cloud/[email protected] (#158)

    9e67576

    fix: upgrade to @google-cloud/[email protected] (#158)

    ce06a3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: clouderrorreportingIssues related to the googleapis/nodejs-error-reporting API.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions