This repository was archived by the owner on Mar 4, 2026. It is now read-only.
Repository navigation
build: update system-test and sample-test config - #1118
Merged
BenWhitehead merged 1 commit intoJun 9, 2020
Merged
Conversation
googlebot
added
the
cla: yes
bcoe
approved these changes
Jun 9, 2020
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
This looks good to me @BenWhitehead, but since we haven't been picking up updates to .kokoro/, we'll need to add the populate-secrets.sh to .kokoro/, as is done here:
and also update the trampoline.sh to call it.
After we do this, I think we might also want to add .kokoro to the exclude rules in synth.py, since this using another service account than our other libraries (I think this is fine, and gets us on our feet).
bcoe
reviewed
Jun 9, 2020
Add new script .kokoro/populate-secrets.sh which supports the new SECRET_MANAGER_KEYS configured for each build. Update kokoro trampoline to call populate-secrets.sh Update system-test config to use a new project `java-review` and a new secret for its credentials. Update samples-test config to use a new project `nodejs-firestore-ci` and a new secret for its credentials.
BenWhitehead
changed the title
bcoe
approved these changes
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new script .kokoro/populate-secrets.sh which supports the new
SECRET_MANAGER_KEYS configured for each build.
Update kokoro trampoline to call populate-secrets.sh
Update system-test config to use a new project
java-reviewand a newsecret for its credentials.
Update samples-test config to use a new project
nodejs-firestore-ciand a new secret for its credentials.