This repository was archived by the owner on Mar 17, 2026. It is now read-only.
Repository navigation
feat: add "with response" versions of ack/nack/modack - #1588
Merged
Merged
Conversation
product-auto-label
Bot
added
size: l
product-auto-label
Bot
added
size: m
feywind
marked this pull request as ready for review
June 16, 2022 21:06
feywind
added
the
do not merge
Collaborator
Author
|
@meleu Unfortunately not. I'm working on finishing up the code work to get full exactly once support, but the approvals are taking a while. |
feywind
removed
the
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds ackWithResponse(), nackWithResponse(), and modAckWithResponse(), along with Promises that will simply complete to Success for this step (doc step 4).