This repository was archived by the owner on Mar 3, 2026. It is now read-only.
Repository navigation
test: fix precondition test - #1481
Merged
Merged
Conversation
This test matches the exact error string from the service, which has changed. Using the reason instead should be more robust. Same as googleapis/java-storage#861 Fixes googleapis#1480
product-auto-label
Bot
added
the
api: storage
google-cla
Bot
added
the
cla: yes
Contributor
Author
|
Going to pair with @shaffeeullah later today on getting this working correctly. |
tritone
marked this pull request as draft
June 4, 2021 16:54
tritone
marked this pull request as ready for review
June 7, 2021 01:28
tritone
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
shaffeeullah
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test matches the exact error string from the service, which
has changed. Using the reason instead should be more robust.
Same as googleapis/java-storage#861
Fixes #1480
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: