Message with message nested in map cannot be created with dict

Generate the python GAPIC library with the following proto:

// in googleapis/google/cloud/mypackge/v1/some.proto
syntax = "proto3";

package google.cloud.mypackage;

message Outer {
    AMap inner = 1;
}

message AMap {
    map<string, Stuff> some_mapping = 1;
}

message Stuff {}

The resulting library cannot be used to create certain Outer messages:

(1)

mypackage.Outer(inner={'some_mapping': {'a': {}}})

raises TypeError: Parameter to MergeFrom() must be instance of same class: expected google.cloud.mypackage.Stuff got dict..

(2)

mypackage.Outer(inner={'some_mapping': {'a': mypackage.Stuff()}})

raises TypeError: Parameter to MergeFrom() must be instance of same class: expected google.cloud.mypackage.Stuff got Stuff..

(3)

mypackage.Outer(inner=mypackage.AMap(some_mapping={'a': mypackage.Stuff()}))

works fine, and builds:

inner {
  some_mapping {
    key: "a"
    value {
    }
  }
}

Minimal reproducing type:

class Boat(proto.Message): 
    class Net(proto.Message): 
        class Mollusc(proto.Message):                                                                                                                                                                                                   
            mass_kg = proto.Field(proto.INT32, number=1) 

        molluscs = proto.MapField(proto.STRING, Mollusc, number=1) 
          
    net = proto.Field(Net, number=1)

b = Boat(net={"molluscs": {"squid": {"mass_kg": 100}}})    # raises an exception

Workaround is to explicitly use types, e.g.

b = Boat(net=Boat.Net(molluscs={"squid": Boat.Net.Mollusc(mass_kg=20)}))

@software-dov

@software-dov Do you have a sense of how easy/hard it would be to fix this? It seems natural for folks to mix mix dict/type instantiation (especially when the request object is big).

@software-dov

@software-dov are there planes to address this issue?

+1

I'm not able to reproduce this issue. Please open a new issue if you're still experiencing the problem.

import google.cloud.mypackage as mypackage
print(mypackage.Outer(inner={'some_mapping': {'a': {}}}))
print(mypackage.Outer(inner={'some_mapping': {'a': mypackage.Stuff()}}))
print(mypackage.Outer(inner=mypackage.AMap(some_mapping={'a': mypackage.Stuff()})))

Tested with protobuf==3.19.5 protobuf==3.20.1 protobuf==4.22.1
results in

inner {
  some_mapping {
    key: "a"
    value {
    }
  }
}

inner {
  some_mapping {
    key: "a"
    value {
    }
  }
}

inner {
  some_mapping {
    key: "a"
    value {
    }
  }
}
``

Navigation Menu

Repository navigation

Message with message nested in map cannot be created with dict #161

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Message with message nested in map cannot be created with dict #161

Description

Activity

software-dov commented on Nov 11, 2020

busunkim96 commented on Oct 6, 2021

kurtqq commented on Feb 13, 2023

orby-fabian commented on Mar 3, 2023

parthea commented on Mar 16, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions